RFR: 1604: Unify behavior in gradlew and gradlew.bat [v2]

Magnus Ihse Bursie ihse at openjdk.org
Tue Sep 20 15:14:48 UTC 2022


On Fri, 16 Sep 2022 17:37:42 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> This patch changes the gradlew.bat script to download and extract Gradle and the JDK in the same locations as the gradlew bash script, so that running either script interchangeably works fine in the same workspace.
>
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restoring mkdir

LGTM.

As an aside, I think it's somewhat scary how we modify the gradlew wrapper. Conceptually, I think that should be provided by gradle, and unchanged by us.

(But changing that is outside the scope of this PR, and I do not have a ready suggestion for how to do this otherwise)

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/skara/pull/1377


More information about the skara-dev mailing list