RFR: 1565: Only poll for updated MRs from GitLab [v11]

Erik Joelsson erikj at openjdk.org
Tue Sep 20 20:13:59 UTC 2022


On Tue, 20 Sep 2022 19:28:44 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Duration.ZERO
>
> forge/src/main/java/org/openjdk/skara/forge/PullRequestPoller.java line 239:
> 
>> 237:             reviewsMap = Map.of();
>> 238:         }
>> 239:         return reviewsMap;
> 
> Just an aesthetic remark. It looks a bit odd that this method has a local variable instead of returning directly, when it is almost the very same as the method above.

Oh, I see what you mean now. Will fix.

-------------

PR: https://git.openjdk.org/skara/pull/1369


More information about the skara-dev mailing list