RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects [v6]

Magnus Ihse Bursie ihse at openjdk.org
Fri Sep 23 13:01:32 UTC 2022

On Fri, 23 Sep 2022 12:50:07 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I agree, the `approval` label is meant to signal that this PR is waiting on/needs approval.
> Ah, I see. Maybe `needs-approval` then?

Or maybe I need to understand the entire labeling workflow better... 

Is this label supposed to signal "this PR is of a kind that needs approval" and all PRs of that kind (i.e., it is a backport made to an update repo) will have that label during their entire life span? Or is it supposed to act like a release blocker (as `ready` but inverted), so when approval is given, then the label is dropped?

I have a hard time figuring out how this PR label relates to the "important" labels in JBS. I think I naively assumed that the PR label should reflect the state of the JBS labels, so you could understand from looking at the PR (and not having to go to JBS) to understand if it was in a state where it needed an approval request in JBS, a JBS approval request had been asked, or an approval had been given or denied in JBS. 

Since that was my mental model, having just a single `approval` label made no sense at all to me.


PR: https://git.openjdk.org/skara/pull/1364

More information about the skara-dev mailing list