RFR: 1562: The method 'CheckRun#findComment' don't need the comment list as parameter

Zhao Song duke at openjdk.org
Fri Sep 23 16:51:30 UTC 2022


On Fri, 23 Sep 2022 14:10:03 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> remove parameter 'comments' in CheckRun#findComment.
>> 
>> remove parameter 'activeReviews' in many method interface.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1074:
> 
>> 1072:             // Calculate and update the status message if needed
>> 1073:             var statusMessage = getStatusMessage(visitor, additionalErrors,
>> 1074:                                                 additionalProgresses, integrationBlockers, isCleanBackport);
> 
> Could you fixup the linebreak here.

Sure, thanks for your advice!

-------------

PR: https://git.openjdk.org/skara/pull/1375


More information about the skara-dev mailing list