RFR: 1364: Jira Issues should be resolved as "Fixed" [v2]

Erik Joelsson erikj at openjdk.org
Fri Sep 23 19:43:58 UTC 2022


On Fri, 23 Sep 2022 19:22:23 GMT, Zhao Song <duke at openjdk.org> wrote:

>> bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 320:
>> 
>>> 318:                     issue.addComment(commitNotification);
>>> 319:                 }
>>> 320:                 if (issue.state() != Issue.State.OPEN) {
>> 
>> Hi @erikj79 , I am wondering whether we need condition here. Do we only update the assignee when the issue is open?
>
> If it it not, I think I should update one assertion in IssueNotifierTests#testAltFixVersionsMatch

oh, forgot to say, same thing here as in the other method. We don't need this conditional.

-------------

PR: https://git.openjdk.org/skara/pull/1382


More information about the skara-dev mailing list