RFR: 1364: Jira Issues should be resolved as "Fixed" [v3]

Zhao Song duke at openjdk.org
Fri Sep 23 20:20:51 UTC 2022


On Fri, 23 Sep 2022 20:00:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove some conditions
>
> bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 195:
> 
>> 193:             // If prOnly is false, this is instead done when processing commits
>> 194:             if (prOnly && resolve) {
>> 195:                 log.info("Resolving issue " + issue.id() + " from state " + issue.state());
> 
> We should keep the log message and the issue.setState call together. I think moving lines 203-207 up here would be best to keep the flow as similar to before as we can. Same applies in the other method.

Sure

-------------

PR: https://git.openjdk.org/skara/pull/1382


More information about the skara-dev mailing list