Integrated: 1858: Make it possible to configure to require reviewers for "Merge" PRs
Zhao Song
zsong at openjdk.org
Tue Apr 4 16:56:07 UTC 2023
On Thu, 30 Mar 2023 18:51:31 GMT, Zhao Song <zsong at openjdk.org> wrote:
> In this patch, PR bot has been added with the capability to control the requirement of reviews for merge pull requests.
>
> By default, review is not necessary for merge pull requests.
>
> However, if it is desired to enable the requirement of reviews for merge requests in a repo, the configuration can be added to the PR bot configuration as follows:
>
> {
> "pr": {
> "repositories": {
> "repo1": {
> "reviewMerge": true
> }
> }
> }
> }
>
>
> Currently, jcheck would run in two places in skara bot. One is in checkRun and one is in IntegrateCommand. For the merge pull requests that not require review, the Reviewers check would be skipped.
>
> The other way to run jcheck in using SKARA CLI. This patch is also compatible with it.
This pull request has now been integrated.
Changeset: fe8efd83
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/fe8efd838011970c034daea65a7d7c0f1ffc9813
Stats: 163 lines in 12 files changed: 135 ins; 7 del; 21 mod
1858: Make it possible to configure to require reviewers for "Merge" PRs
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1495
More information about the skara-dev
mailing list