RFR: 1858: Make it possible to configure to require reviewers for "Merge" PRs [v4]

Zhao Song zsong at openjdk.org
Tue Apr 4 16:56:07 UTC 2023

On Tue, 4 Apr 2023 15:50:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In this patch, PR bot has been added with the capability to control the requirement of reviews for merge pull requests.
>> By default, review is not necessary for merge pull requests.
>> However, if it is desired to enable the requirement of reviews for merge requests in a repo, the configuration can be added to the PR bot configuration as follows:
>> {
>>   "pr": {
>>       "repositories": {
>>           "repo1": {
>>                "reviewMerge": true
>>           }
>>        }
>>   }
>> }
>> Currently, jcheck would run in two places in skara bot. One is in checkRun and one is in IntegrateCommand. For the merge pull requests that not require review, the Reviewers check would be skipped.
>> The other way to run jcheck in using SKARA CLI. This patch is also compatible with it.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   fix some problems

Thanks for the review!


PR Comment: https://git.openjdk.org/skara/pull/1495#issuecomment-1496299817

More information about the skara-dev mailing list