RFR: 1850: CSR bot can pick up wrong fix version if PR branch is behind target branch

Zhao Song zsong at openjdk.org
Tue Apr 4 21:46:27 UTC 2023

On Tue, 4 Apr 2023 21:41:04 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > > Some tests fail because now, the bot would post a 'fixVersion' comment. I will fix the failed tests if this pr is approved.
> > 
> > 
> > Hold off on that. I'm not sure this new comment is the right solution. I need to think about this.
> I think we need to perform the merge in `CSRCommand` for this to work. It would have to instantiate `CheckablePullRequest` and call merge. Not sure if any code can be abstracted out of `CheckRun` to be shared here. At least the logic for extracting the version from `.jcheck/conf` should be possible to share between CheckRun and CSRCommand. Maybe it belongs in `CheckablePullRequest` now?
> Also in `CSRCommand` we are currently getting the version in the issues loop, so that call is repeated for all issues. Please move the new call to get version to before the loop instead.

I was thinking that perform merge every time maybe not very efficient. But CSR commands might not be used very frequently. I would follow your advice. Thanks!


PR Comment: https://git.openjdk.org/skara/pull/1496#issuecomment-1496642734

More information about the skara-dev mailing list