RFR: 1850: CSR bot can pick up wrong fix version if PR branch is behind target branch [v2]

Zhao Song zsong at openjdk.org
Wed Apr 5 20:31:18 UTC 2023

On Wed, 5 Apr 2023 19:53:18 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>   SKARA-1850
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1180:
>> 1178:             }
>> 1179: 
>> 1180:             var confFile = localRepo.show(Path.of(".jcheck/conf"), localHash);
> I recommend using `localRepo.lines` here instead of `show`, then you don't need to be responsible for knowing the encoding of the file contents on line 1183.

Sure. Thanks!


PR Review Comment: https://git.openjdk.org/skara/pull/1496#discussion_r1158990576

More information about the skara-dev mailing list