RFR: 1850: CSR bot can pick up wrong fix version if PR branch is behind target branch [v5]

Zhao Song zsong at openjdk.org
Thu Apr 6 17:19:45 UTC 2023


On Thu, 6 Apr 2023 16:37:42 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix line break issues
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java line 66:
> 
>> 64:     private static void singleIssueLinkReply(PullRequest pr, PrintWriter writer) {
>> 65:         writer.println("@" + pr.author().username() + " please create a [CSR](https://wiki.openjdk.org/display/csr/Main) request, with the correct fix version, for the issue associated with this pull request." +
>> 66:                 " This pull request cannot be integrated until the CSR request is approved.");
> 
> Can we restore the link to the main issue?

Sure, will fix it soon

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1496#discussion_r1160062573


More information about the skara-dev mailing list