RFR: 1853: Make it possible to disable merge PRs for a repository [v2]
Zhao Song
zsong at openjdk.org
Tue Apr 11 18:33:26 UTC 2023
On Tue, 11 Apr 2023 18:03:54 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
>>
>> Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 263:
>
>> 261: return List.of();
>> 262: }
>> 263: removeErrorComment(mergeDisabledText, comments);
>
> I think this whole check should be moved inside the `currentCheckValid` block. The check is cheap, but I still think it should be grouped with other similar checks.
>
> I don't think we should remove error comments. None of the other similar comments are removed, so unless we want to change that, then this new comment shouldn't be either.
I thought if we put the check on the top of the method, it would help us save some rest api calls. I am also ok with moving it inside the currentCheckValid block.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1499#discussion_r1163185530
More information about the skara-dev
mailing list