RFR: 1854: Add "clean" label for merge PRs that have no merge resolution [v3]

Zhao Song zsong at openjdk.org
Wed Apr 12 23:22:55 UTC 2023

On Wed, 12 Apr 2023 23:19:23 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> vcs/src/main/java/org/openjdk/skara/vcs/Repository.java line 186:
>>> 184:     }
>>> 185: 
>>> 186:     boolean isEmptyCommit(Hash hash);
>> We should add a javadoc comment describing the expected behavior for this method, specifically for merge commits.
> Sure. But I think it also works for simple empty commit(not merge commit)

At first, I name this method as `isEmptyMergeCommit` and later I thought it also works for simple empty commit, so I changed the method name to `isEmptyCommit`


PR Review Comment: https://git.openjdk.org/skara/pull/1500#discussion_r1164753601

More information about the skara-dev mailing list