RFR: 1879: Make GitRepository#isEmptyCommit be compatible with old versions of Git

Erik Joelsson erikj at openjdk.org
Thu Apr 13 20:06:35 UTC 2023


On Thu, 13 Apr 2023 17:32:47 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In SKARA-1854, we introduced a method GitRepository#isEmptyCommit. In addition, the git show command includes the option '--diff-merges=dense-combined' in git 2.30.0. However, this option is not available in old versions of git. To ensure compatibility with old versions of Git, we should replace '--diff-merges=dense-combined' with the '--cc' option.
> 
> References:
> [1]https://git-scm.com/docs/git-show/2.29.0
> [2]https://git-scm.com/docs/git-show/2.30.0

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1501#pullrequestreview-1384083296


More information about the skara-dev mailing list