RFR: 1878: Improve argument check in SKARA CLI

Erik Joelsson erikj at openjdk.org
Fri Apr 14 12:50:57 UTC 2023

On Thu, 13 Apr 2023 22:54:06 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, if a user misuses a command, in some cases, SKARA CLI crashes and throws a stack trace, which is bad and does not provide useful information to the user. 
> After investigating, I found that in many places, we don't check whether an option is followed by an argument, and it would trigger some issues.
> In this patch, the program would always check the presence of an argument  before attempting to retrieve it for an option.

Good fix overall. I see you updated copyright years in some files, please make sure all the files you have changed are updated.

cli/src/main/java/org/openjdk/skara/cli/GitSync.java line 345:

> 343:                     branches.add(branch.trim());
> 344:                 }
> 345:             }

What happened to this part?


PR Review: https://git.openjdk.org/skara/pull/1502#pullrequestreview-1385391787
PR Review Comment: https://git.openjdk.org/skara/pull/1502#discussion_r1166790630

More information about the skara-dev mailing list