RFR: 1878: Improve argument check in SKARA CLI [v2]
Erik Joelsson
erikj at openjdk.org
Fri Apr 14 17:12:39 UTC 2023
On Fri, 14 Apr 2023 16:14:46 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> Currently, if a user misuses a command, in some cases, SKARA CLI crashes and throws a stack trace, which is bad and does not provide useful information to the user.
>>
>> After investigating, I found that in many places, we don't check whether an option is followed by an argument, and it would trigger some issues.
>>
>> In this patch, the program would always check the presence of an argument before attempting to retrieve it for an option.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> update copyright
Looks good!
-------------
Marked as reviewed by erikj (Lead).
PR Review: https://git.openjdk.org/skara/pull/1502#pullrequestreview-1385873867
More information about the skara-dev
mailing list