RFR: 1855: Make it configurable which repositories merges should be allowed from

[Erik Joelsson]

On Mon, 17 Apr 2023 21:29:24 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In this patch, PR bot has been added with the capability to control which repositories can be the source for Merge-style pull requests.
> 
> By default, all repositories are allowed.
> 
> However, if it is desired to configure "allowed" repos, the configuration can be added to the PR bot configuration as follows:
> 
> {
>   "pr": {
>       "repositories": {
>           "repo1": {
>                "mergeSources": [openjdk/repo2, openjdk/repo3]
>           }
>        }
>   }
> }
> 
> 
> And the repo itself can always be the source of Merge-style pull requests.

Looks good, just a minor nit.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 319:

> 317:                             var mergeSourceInvalidText = "<!-- merge error -->\n" +
> 318:                                     ":warning: @" + pr.author().username() + " " + repoName +
> 319:                                     " can not be source repo for Merge-style pull requests in this repository.\n" +

Suggestion:

                                    " can not be source repo for merge-style pull requests in this repository.\n" +

-------------

Marked as reviewed by erikj (Lead).

PR Review: https://git.openjdk.org/skara/pull/1503#pullrequestreview-1390439424
PR Review Comment: https://git.openjdk.org/skara/pull/1503#discussion_r1170240357