RFR: 1885: Add method deleteDeployKeys to HostedRepository [v2]

Zhao Song zsong at openjdk.org
Wed Apr 19 22:24:49 UTC 2023


On Wed, 19 Apr 2023 22:14:47 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use duration
>
> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java line 837:
> 
>> 835:                 .stream()
>> 836:                 .filter(key -> ZonedDateTime.parse(key.get("created_at").asString())
>> 837:                         .isBefore(ZonedDateTime.now().minusSeconds(duration.toSeconds())))
> 
> No need to convert to seconds when using `Duration`. It implements `TemporalAmount` so you can just:
> Suggestion:
> 
>                         .isBefore(ZonedDateTime.now().minus(duration)))

Good to know. Will fix it too.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1505#discussion_r1171905485


More information about the skara-dev mailing list