RFR: 1890: Add method getExpiredDeployKeys [v2]

Erik Joelsson erikj at openjdk.org
Tue Apr 25 22:48:46 UTC 2023

On Tue, 25 Apr 2023 22:25:56 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Add a new method called getExpiredDeployKeys in HostedRepository
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   update method name

Maybe also update the bug title? I would recommend not mentioning the exact method name in the title, but instead describing the new API. Something like "Add API to get deploy keys for a repository".

forge/src/test/java/org/openjdk/skara/forge/github/GitHubRestApiTests.java line 273:

> 271: 
> 272:     @Test
> 273:     void testGetExpiredDeployKeys() {

Update test name?


PR Review: https://git.openjdk.org/skara/pull/1508#pullrequestreview-1400865122
PR Review Comment: https://git.openjdk.org/skara/pull/1508#discussion_r1177136067

More information about the skara-dev mailing list