RFR: 1984: SKARA bot couldn't handle jep command if the jep doesn't have JEP Number

Zhao Song zsong at openjdk.org
Wed Aug 2 22:01:07 UTC 2023

On Wed, 2 Aug 2023 21:55:31 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> A user issued command /jep JDK-8310626 in https://github.com/openjdk/jdk/pull/15103 and skara bot kept throwing exceptions because the JEP doesn't have a JEP number. 
>> @kevinrushforth suggested that it makes more sense to make skara bot be able to associate a PR with a JEP before it is a Candidate.
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/JEPCommand.java line 147:
>> 145:             // The current issue status may be "Draft", "Submitted", "Candidate", "Proposed to Target", "Proposed to Drop" or "Closed without Delivered"
>> 146:             if (jepNumber.equals("NotAllocated")) {
>> 147:                 reply.println("This pull request will not be integrated until the [" + jbsIssue.id()
> Minor: I would add the word "JEP" before the `jbsIssue.id()` here.

Do you mean  [JEP JDK-8310626][url] or JEP [JDK-8310626][url]?


PR Review Comment: https://git.openjdk.org/skara/pull/1541#discussion_r1282458074

More information about the skara-dev mailing list