RFR: 1979: MailingListNotifier will not send an email notification when the first branch of some repos is created
Erik Joelsson
erikj at openjdk.org
Wed Aug 9 18:47:54 UTC 2023
On Tue, 1 Aug 2023 21:10:11 GMT, Zhao Song <zsong at openjdk.org> wrote:
> A Leyden committer created a new branch (pregenerate-lambdas) and pushed to it, but skara bot didn't sent email notification to [leyden-dev at openjdk.org](mailto:leyden-dev at openjdk.org).
>
> After investigating, I found the reason is that in the configuration of NotifyBot, we configured branches as '!master'. Due to this configuration, 'master' branch would be ignored in knownRefs. Therefore, in method RepositoryWorkItem#handleNewRef, The NotifyBot would not be able to find a candidate and it will return immediately.
>
> In this patch, defaultBranch would always be included in the candidate refs.
This is a nice catch. Looks good!
-------------
Marked as reviewed by erikj (Lead).
PR Review: https://git.openjdk.org/skara/pull/1539#pullrequestreview-1570327312
More information about the skara-dev
mailing list