RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects

Erik Joelsson erikj at openjdk.org
Wed Aug 9 20:39:09 UTC 2023

On Fri, 30 Jun 2023 17:58:57 GMT, Zhao Song <zsong at openjdk.org> wrote:

> And now I am thinking why we only post `approvalNeededComment` when a PR is ready with everything but approval? What about posting `approvalNeededComment` when approval is missing? In this way, user could see the instructions earlier and they would have the time to apply for approval.

I think we should refrain from posting it early because the formal approval process shouldn't start until the PR is reviewed. Posting the comment early might encourage users to post approval requests early, which will annoy the maintainers.


PR Comment: https://git.openjdk.org/skara/pull/1537#issuecomment-1672112905

More information about the skara-dev mailing list