RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects [v5]

[Erik Joelsson]

On Fri, 11 Aug 2023 13:17:31 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - fix test
>>  - fix test
>>  - update
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1517:
> 
>> 1515:         }
>> 1516:         String message = "⚠️  @" + pr.author().username() +
>> 1517:                 " This change has now been reviewed and requires maintainer [approval](" + approval.documentLink() + ")." +
> 
> I did some more thinking about how this should be formulated. I don't think we should mention the review state here either. 
> Suggestion:
> 
>                 " This change is now ready for maintainer [approval](" + approval.documentLink() + ")." +

Suggestion:

                " This change is now ready for you to apply for maintainer [approval](" + approval.documentLink() + ")." +

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1537#discussion_r1291341597