RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects [v5]
Zhao Song
zsong at openjdk.org
Fri Aug 11 16:31:33 UTC 2023
On Fri, 11 Aug 2023 13:19:21 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - fix test
>> - fix test
>> - update
>
> bots/pr/src/test/java/org/openjdk/skara/bots/pr/ApprovalTests.java line 34:
>
>> 32: @Test
>> 33: void simple() {
>> 34: Approval approval = new Approval("", "jdk17u-fix-request", "jdk17u-fix-yes", "jdk17u-fix-no", "https://test.openjdk.org");
>
> I recommend using something with `example.com` for test URL.
Sure, will fix it.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1537#discussion_r1291557127
More information about the skara-dev
mailing list