RFR: 1949: Handle maintainer approval from pull request

Zhao Song zsong at openjdk.org
Wed Aug 16 16:42:53 UTC 2023

On Wed, 16 Aug 2023 12:40:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > Only maintainers of the repo are allowed to issue this command. Maintainers can approve or reject the approval whether the request exists.
> I don't think we should allow approve without a request (unless the current maintainers agree they want it to work that way).
> > If there is only one issue associated with the pr, the user will not need to specify the issue id. If there are more than one issues associated with the pr, the user should specify the issue id in the command.
> At least for the /approve command, running without an issue id should approve all associated issues that have approval requested. One of the main reasons for allowing approve from PR is to automatically handle multiple bugs.

Will fix the issues you mentioned. Also thanks for improving the messages.


PR Comment: https://git.openjdk.org/skara/pull/1544#issuecomment-1680936944

More information about the skara-dev mailing list