RFR: 1949: Handle maintainer approval from pull request [v2]

Zhao Song zsong at openjdk.org
Thu Aug 17 16:59:45 UTC 2023


On Thu, 17 Aug 2023 16:41:28 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with 21 additional commits since the last revision:
>> 
>>  - update
>>  - fix test
>>  - reviewComment
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApproveCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApprovalCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApproveCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApproveCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApprovalCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApprovalCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - ... and 11 more: https://git.openjdk.org/skara/compare/aab28673...e488acc6
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApprovalCommand.java line 126:
> 
>> 124:                         reply.println("The approval [request](" + issueTrackerIssue.commentUrl(comment) + ") has been updated successfully.");
>> 125:                     } else {
>> 126:                         reply.println("The approval request was already up to date.");
> 
> Should link here too.

Sure

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1544#discussion_r1297493265


More information about the skara-dev mailing list