RFR: 1949: Handle maintainer approval from pull request [v4]
Zhao Song
zsong at openjdk.org
Thu Aug 17 20:08:01 UTC 2023
On Thu, 17 Aug 2023 19:56:42 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - update
>> - update
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 682:
>
>> 680: progressBody.append("\n");
>> 681:
>> 682: var existingRequested = false;
>
> This variable name confuses me. I would suggest `requestPresent`.
Sure
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1544#discussion_r1297680032
More information about the skara-dev
mailing list