RFR: 1999: Only post ApprovalNeededComment after pr is otherwise ready for integration [v2]

Zhao Song zsong at openjdk.org
Mon Aug 21 20:29:37 UTC 2023


> In [SKARA-1199](https://bugs.openjdk.org/browse/SKARA-1199), I made a bug about posting approvalNeededComment. 
> 
> Before the bot posting ApprovalNeededComment, we need to make sure this pr could pass all the checks.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  fix another problem

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1546/files
  - new: https://git.openjdk.org/skara/pull/1546/files/63f915f1..c6a87205

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1546&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1546&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/skara/pull/1546.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1546/head:pull/1546

PR: https://git.openjdk.org/skara/pull/1546


More information about the skara-dev mailing list