RFR: 1999: Only post ApprovalNeededComment after pr is otherwise ready for integration [v2]

[Zhao Song]

On Mon, 21 Aug 2023 21:42:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix another problem
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1335:
> 
>> 1333:             }
>> 1334: 
>> 1335:             if (approvalNeeded() && visitor.messages().isEmpty()) {
> 
> Is this enough? Shouldn't we check `readyForReview` as well. What about the other things in the list for `readyForIntegration`?

You are right. I will fix the problem soon. Thank you.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1546#discussion_r1300707125