RFR: 1999: Only post ApprovalNeededComment after pr is otherwise ready for integration [v3]

Zhao Song zsong at openjdk.org
Mon Aug 21 23:22:44 UTC 2023

> In [SKARA-1199](https://bugs.openjdk.org/browse/SKARA-1199), I made a bug about posting approvalNeededComment. 
> Before the bot posting ApprovalNeededComment, we need to make sure this pr could pass all the checks.
> This PR also solves an issue in /approve command. If the command issuer is not an integrator, then the bot should return immediately.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:



  - all: https://git.openjdk.org/skara/pull/1546/files
  - new: https://git.openjdk.org/skara/pull/1546/files/c6a87205..d6a5cbdc

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1546&range=02
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1546&range=01-02

  Stats: 23 lines in 1 file changed: 7 ins; 12 del; 4 mod
  Patch: https://git.openjdk.org/skara/pull/1546.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1546/head:pull/1546

PR: https://git.openjdk.org/skara/pull/1546

More information about the skara-dev mailing list