RFR: 1999: Only post ApprovalNeededComment after pr is otherwise ready for integration [v3]

Erik Joelsson erikj at openjdk.org
Tue Aug 22 13:19:20 UTC 2023

On Mon, 21 Aug 2023 23:22:44 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In [SKARA-1199](https://bugs.openjdk.org/browse/SKARA-1199), I made a bug about posting approvalNeededComment. 
>> Before the bot posting ApprovalNeededComment, we need to make sure this pr could pass all the checks.
>> This PR also solves an issue in /approve command. If the command issuer is not an integrator, then the bot should return immediately.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   update

Marked as reviewed by erikj (Lead).


PR Review: https://git.openjdk.org/skara/pull/1546#pullrequestreview-1589423463

More information about the skara-dev mailing list