Integrated: 1999: Only post ApprovalNeededComment after pr is otherwise ready for integration
Zhao Song
zsong at openjdk.org
Tue Aug 22 16:11:08 UTC 2023
On Mon, 21 Aug 2023 19:49:51 GMT, Zhao Song <zsong at openjdk.org> wrote:
> In [SKARA-1199](https://bugs.openjdk.org/browse/SKARA-1199), I made a bug about posting approvalNeededComment.
>
> Before the bot posting ApprovalNeededComment, we need to make sure this pr could pass all the checks.
>
> This PR also solves an issue in /approve command. If the command issuer is not an integrator, then the bot should return immediately.
This pull request has now been integrated.
Changeset: c31c8b4d
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/c31c8b4dd7ac2debe1ee09bd042ad66c41ebf874
Stats: 26 lines in 4 files changed: 10 ins; 12 del; 4 mod
1999: Only post ApprovalNeededComment after pr is otherwise ready for integration
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1546
More information about the skara-dev
mailing list