RFR: 1994: Reply from /reviewer credit can be clearer

Erik Joelsson erikj at openjdk.org
Wed Aug 23 13:58:54 UTC 2023


On Tue, 22 Aug 2023 17:38:30 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch improved the bot's reply in some cases when the pr author issues '/reviewer <user>' command.
> 
> When the pr author is trying to credit an user with '/reviewer <user>' command,
> 
> If the user already approved this pr, Skara bot should reply "Reviewer <user> has already made an authenticated review of this PR, and does not need to be credited manually." 
> 
> If the user already reviewed this pr(but not approved), Skara bot should reply "Reviewer <user> has already made an authenticated review of this PR, but did not approve it. Manually crediting them is not allowed."

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1547#pullrequestreview-1591671142


More information about the skara-dev mailing list