RFR: 2010: Handle both ignoreopt and matchprefix together in IssueNotifier

Zhao Song zsong at openjdk.org
Wed Aug 30 22:43:18 UTC 2023

On Wed, 30 Aug 2023 19:39:47 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The two configuration options for tags in the IssueNotifier, "ignoreopt" and "matchprefix" do not work together if "matchprefix" is set to false (which is the default value). We need to configure a repository where the tag format and the fixVersion differ in both prefix and "opt" suffix. This patch fixes this by reordering the logic in `tagVersionMatchesFixVersion`. I added a test to verify this specific situation. I believe the existing tests should cover all other current usecases.

Looks good!


Marked as reviewed by zsong (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1551#pullrequestreview-1603593230

More information about the skara-dev mailing list