RFR: 2082: Use correct .jcheck/conf in AdditionalConfiguration.java [v6]

Erik Joelsson erikj at openjdk.org
Fri Dec 1 17:55:46 UTC 2023


On Fri, 1 Dec 2023 15:23:09 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that ensures that we pass the correct `.jcheck/conf` to [AdditionalConfiguration.java](https://github.com/openjdk/skara/blob/master/bots/pr/src/main/java/org/openjdk/skara/bots/pr/AdditionalConfiguration.java). The `.jcheck/conf` should either come from the "overriding" `.jcheck/conf` (if the PR bot is configured to use that) or the pull request's target branch.
>> 
>> I have added that test that passes with this patch but fails without it.
>> 
>> Thanks,
>> Erik
>
> Erik Duveblad has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
> 
>  - Merge branch 'master' into pr-correct-jcheck-conf
>  - Reviewer feedback
>  - Merge 'master'
>  - Reviewer feedback
>  - Merge master
>  - optimize
>  - final review
>  - refactor
>  - whitespace
>  - do not throw from checkStatus
>  - ... and 3 more: https://git.openjdk.org/skara/compare/b5752053...1b6ddac9

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1578#pullrequestreview-1760313456


More information about the skara-dev mailing list