Integrated: 2082: Use correct .jcheck/conf in AdditionalConfiguration.java

Erik Duveblad ehelin at openjdk.org
Mon Dec 4 09:54:23 UTC 2023


On Fri, 27 Oct 2023 08:32:26 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that ensures that we pass the correct `.jcheck/conf` to [AdditionalConfiguration.java](https://github.com/openjdk/skara/blob/master/bots/pr/src/main/java/org/openjdk/skara/bots/pr/AdditionalConfiguration.java). The `.jcheck/conf` should either come from the "overriding" `.jcheck/conf` (if the PR bot is configured to use that) or the pull request's target branch.
> 
> I have added that test that passes with this patch but fails without it.
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: da8baf07
Author:    Erik Duveblad <ehelin at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/da8baf07ddffb58323582bfd6f4e40f8b18440d7
Stats:     191 lines in 9 files changed: 111 ins; 4 del; 76 mod

2082: Use correct .jcheck/conf in AdditionalConfiguration.java

Reviewed-by: erikj, zsong

-------------

PR: https://git.openjdk.org/skara/pull/1578


More information about the skara-dev mailing list