Integrated: 2111: Normalize usernames before comparing
Zhao Song
zsong at openjdk.org
Wed Dec 6 00:10:33 UTC 2023
On Tue, 5 Dec 2023 17:22:56 GMT, Zhao Song <zsong at openjdk.org> wrote:
> In https://github.com/openjdk/jdk/pull/16788#issuecomment-1827984539, although the user's full name and the head commit author's name seems exactly same in the GitHub. The bot was thinking they are different, Erik pointed out the root cause "The problem was that a unicode character was encoded differently, one as a composition and one as a single character. "
>
> To avoid this kind of problems in the future, we should normalize the strings before comparison to ensure unicode characters are encoded in the same way.
This pull request has now been integrated.
Changeset: 20edc895
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/20edc895375f9c4c37b3b8a7289e9db6e9d16c77
Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
2111: Normalize usernames before comparing
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1591
More information about the skara-dev
mailing list