RFR: 1797: Add support for /backport pull request command

Thomas Stüfe thomas.stuefe at gmail.com
Thu Feb 2 14:05:47 UTC 2023


On Thu, Feb 2, 2023 at 3:00 PM <erik.joelsson at oracle.com> wrote:

> On 2/2/23 05:30, Thomas Stüfe wrote:
>
> Hi Erik :)
>
> p.s. there is one detail I did not understand:
>
> "With Zhao’s patch a user can now instead type `/backport` in the pull
> request and the Skara bots will create the “backport pull request” once the
> pull request has been integrated."
>
> Today, /backport does not create a pull request, or? It only creates the
> backport branch; the pull request creation is still a manual step - either
> a button press or a manual process via git. So, will /backport in an open
> PR behave differently from that and create the PR right away?
>
> You are correct, the `/backport` command only creates the branch and
> provides a link for creating the backport. That isn't changing. When
> issuing `/backport` in a pull request the difference is that the link
> appears as a comment on the pull request instead of the commit.
>

Thanks for clarifying!

> Another aspect of this change is that the author can use it to declare
> their intent of backporting the change to a certain release, which
> reviewers have the opportunity to respond to directly in the current review.
>

Okay, this could be useful. Especially if Reviewers don't monitor the
updates ML.


> /Erik
>

..Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/skara-dev/attachments/20230202/73e6a98b/attachment.htm>


More information about the skara-dev mailing list