RFR: 1797: Add support for /backport pull request command [v4]
Erik Joelsson
erikj at openjdk.org
Mon Feb 6 21:14:16 UTC 2023
On Wed, 1 Feb 2023 22:39:37 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 208:
>>
>>> 206: var botComment = allComments.stream()
>>> 207: .filter(comment -> comment.author().equals(bot.repo().forge().currentUser()))
>>> 208: .filter(comment -> comment.body().contains("Backport for repo `" + repoName + "` on branch `" + targetBranchName + "` was successfully enabled."))
>>
>> Instead of parsing the human readable message, I would recommend encoding a more structured data entry in an html comment. That will be easier to parse and less sensitive to future changes of this code. There should be several similar examples of that throughout the bots.
>
> Sure. Will fix it
I don't think you changed this.
-------------
PR: https://git.openjdk.org/skara/pull/1466
More information about the skara-dev
mailing list