RFR: 1813: URLs printed by Skara should have ".git" at the end of the repo name [v2]
Erik Joelsson
erikj at openjdk.org
Wed Feb 8 22:54:39 UTC 2023
On Wed, 8 Feb 2023 21:54:35 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> In this patch, `.git` is added to the URLs printed by Skara.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> add method HostedRepository#remoteUrl
This is better. There are more places that need to use the new method. The fallback instructions for /backport is one example where I just saw URLs with no .git in example command lines.
forge/src/main/java/org/openjdk/skara/forge/HostedRepository.java line 86:
> 84: URI diffUrl(String prId);
> 85: VCS repositoryType();
> 86: URI remoteUrl();
Suggestion:
/**
* Returns a URL suitable for CLI interactions with the repository
*/
URI remoteUrl();
-------------
PR: https://git.openjdk.org/skara/pull/1467
More information about the skara-dev
mailing list