RFR: 1813: URLs printed by Skara should have ".git" at the end of the repo name [v4]

Zhao Song zsong at openjdk.org
Wed Feb 8 23:42:26 UTC 2023

On Wed, 8 Feb 2023 23:22:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>   use remoteUrl() in more places
> bots/checkout/src/main/java/org/openjdk/skara/bots/checkout/CheckoutBot.java line 67:
>> 65: 
>> 66:     private URI webURI() {
>> 67:         var webURI = from.remoteUrl().toString();
> Converting from URI to String and then back to URI doesn't seem like a good idea. This method is called in one place, so should probably just get rid of it.

Oh, I didn't find this redundant operation.


PR: https://git.openjdk.org/skara/pull/1467

More information about the skara-dev mailing list