RFR: 1588: Bridge messages should not be sent for PRs in draft state

Kevin Rushforth kcr at openjdk.org
Thu Feb 9 19:27:35 UTC 2023

On Thu, 9 Feb 2023 17:48:28 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> This patch prevents the `mailling bridge bot` from sending emails when a PR is draft.
> And the related test case is added.
> Thanks for taking the time to review.
> Best Regards,
> -- Guoxiong

Not sure whether this is sufficient. See my question below.

bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java line 206:

> 204:         List<PullRequest> prs = poller.updatedPullRequests();
> 205:         prs.stream()
> 206:                 .filter(pr -> !pr.isDraft())

Are you sure this is the right place to do this? The intention of this fix is to pause notifications for Draft PRs until it becomes "rfr" again, just like it currently does for PRs initially in Draft that become "rfr" for the first time. Will it do this or will it just lose the notifications permanently?


PR: https://git.openjdk.org/skara/pull/1469

More information about the skara-dev mailing list