RFR: 1706: Store github checks in PR unique way

Zhao Song zsong at openjdk.org
Thu Feb 9 21:10:52 UTC 2023

On Thu, 9 Feb 2023 19:13:37 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, checks in GitHub are stored in the commit. So if multiple PRs share the same source commit, then they will compete with the check-runs and store their different checksum in there. This in turn means that all, or most of those PRs will always think the check is outdated when a CheckRun is performed next.
> This patch adds repository name and pull request id to the name of check in Github. Therefore, even if multiple PRs share the same source commit, every PR will store a unique check in the commit and there is no competition exists.

Checked the [checkrun](https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#get-a-check-run) document in GitHub and I found the document says there will be an `id` for every check-run. The document also says if we want to update the check-run, `id` is required in the header. But in `GitHubPullRequest#updateCheck`, I don't think we have anything related with `id`. Therefore I am wondering how could we update the check in GitHub, do we update the checks by the name?


PR: https://git.openjdk.org/skara/pull/1470

More information about the skara-dev mailing list