RFR: 1706: Store github checks in PR unique way [v2]

Erik Joelsson erikj at openjdk.org
Thu Feb 9 23:00:35 UTC 2023

On Thu, 9 Feb 2023 22:22:51 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java line 64:
>>> 62:         final var outdated = "the status check `" + checkName + "` has not been performed on commit %s yet";
>>> 63: 
>>> 64:         checkName = checkName.equals("jcheck") && pr.repository().forge().name().equals("GitHub") ?
>> There is just one caller of this method, which explicitly calls with `"jcheck"`. The caller should generate the new check name instead of rewriting it here.
> But in that way, the checkName will be "jcheck-repo#pull" and the error message showed to user would be "the status check jcheck-repo#pull is still in progress".

I think that's what we want. That's the name the check will have in the GitHub UI as well.


PR: https://git.openjdk.org/skara/pull/1470

More information about the skara-dev mailing list