RFR: 1706: Store github checks in PR unique way [v2]

Erik Joelsson erikj at openjdk.org
Thu Feb 9 23:04:09 UTC 2023


On Thu, 9 Feb 2023 22:40:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Currently, checks in GitHub are stored in the commit. So if multiple PRs share the same source commit, then they will compete with the check-runs and store their different checksum in there. This in turn means that all, or most of those PRs will always think the check is outdated when a CheckRun is performed next.
>>  
>> This patch adds repository name and pull request id to the name of check in Github. Therefore, even if multiple PRs share the same source commit, every PR will store a unique check in the commit and there is no competition exists.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix problems

I think this looks ok. Could you run it in staging and verify that it works and looks ok before integrating?

-------------

PR: https://git.openjdk.org/skara/pull/1470


More information about the skara-dev mailing list