RFR: 1706: Store github checks in PR unique way [v2]

Zhao Song zsong at openjdk.org
Fri Feb 10 17:20:53 UTC 2023

On Fri, 10 Feb 2023 12:28:09 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> > I think it works fine. Currently, each pr would have a unique jcheck. https://github.com/openjdk/playground/pull/126/checks?check_run_id=11239907703
> From the link you provided, I notice there are three items `jcheck`, `jcheck-openjdk/playground-125` and `jcheck-openjdk/playground-126` under the `openjdk`. And the `PR-125`, which is sooner than `PR-126`, also has these three items, please see https://github.com/openjdk/playground/pull/125/checks.
> And the `checks`, please see https://github.com/openjdk/skara/pull/1470/checks, of this pull request, it contains both `jcheck` and `jcheck-openjdk/skara-1470`. And under the `All checks have passed` of this page (this pull request page), it also has two items `jcheck` and `jcheck-openjdk/skara-1470`. It is so strange. I suspect the current patch is not the right solution.

For the PRs in playground, they contain `jcheck-openjdk/playground-125` and `jcheck-openjdk/playground-126` because PR-125 and PR-126 share the same source commit and testinfo bot will copy all the tests under the source commit. They also contain `jcheck` because after testing, I revert the staging bot, so it will have a normal `jcheck`. 

For this PR in SKARA,  it contains `jcheck-openjdk/skara-1470` because SKARA is also configured to pr bot in staging in our configuration. 

I think after implementing the filter logic in testinfo bot, the checks will look better.

Thank you!


PR: https://git.openjdk.org/skara/pull/1470

More information about the skara-dev mailing list