RFR: 1706: Store github checks in PR unique way [v2]

Zhao Song zsong at openjdk.org
Fri Feb 10 22:20:42 UTC 2023


On Fri, 10 Feb 2023 22:11:06 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > Sorry, what I said is confusing. What I should say is that, jcheck is not triggered by the workflow, it is triggered by Checkrun. So it is not stored in the our own fork and then be copied to the pr.
> 
> Right, but then how did we see all the different `jcheck-<repo>-<pull>` in the "checks" tab? Is that just github showing every check related to a commit? If so, I suppose it's ok, the naming should help telling them apart.

My test yesterday is not very good. I  created multiple pull requests with the same source commit within a single repository, whereas the problem this patch was intended to address was creating multiple pull requests with the same source commit in different repositories.

-------------

PR: https://git.openjdk.org/skara/pull/1470


More information about the skara-dev mailing list