RFR: 1588: Bridge messages should not be sent for PRs in draft state [v2]

Zhao Song zsong at openjdk.org
Mon Feb 13 18:14:05 UTC 2023

On Sat, 11 Feb 2023 12:19:48 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch prevents the `mailling bridge bot` from sending emails when a PR is draft.
>> And the related test case is added.
>> Thanks for taking the time to review.
>> Best Regards,
>> -- Guoxiong
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Filter the comments in method ArchiveWorkItem#ignoreComment

Now, I could remember that my implementation of [SKARA-1683](https://github.com/openjdk/skara/pull/1426) shares the same issue with Li's first version.  I had previously mentioned in that pr "My current implementation has a bug. If a user force-pushes or rebases when the pr is in ready state, and then he converts the pr to draft state very quickly, in such a case, our pullRequestBot won't have enough time to send warning, and then user will never get the notification of this force-push or rebase.". I will fix this issue later this week .


PR: https://git.openjdk.org/skara/pull/1469

More information about the skara-dev mailing list