RFR: 1706: Store github checks in PR unique way [v2]

Zhao Song zsong at openjdk.org
Mon Feb 13 21:13:18 UTC 2023


On Mon, 13 Feb 2023 14:15:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > My test yesterday is not very good. I created multiple pull requests with the same source commit within a single repository, whereas the problem this patch was intended to address was creating multiple pull requests with the same source commit in different repositories.
> 
> I would say the intention is to handle both situations.

Yes, seems like that checks cannot be stored within a specific PR and must instead be stored in a specific commit. I also reviewed the GitHub documentation, it seems that it is not possible to hide certain checks within a PR. I am afraid that I am unable to improve the current code, however, I believe that it will work correctly. The names of the checks will indicate to the user which one is associated with the PR, and only the relevant check will have impact. Checks from other PRs will not be an integrationBlocker for this PR.

-------------

PR: https://git.openjdk.org/skara/pull/1470


More information about the skara-dev mailing list