RFR: 1588: Bridge messages should not be sent for PRs in draft state [v3]

Erik Joelsson erikj at openjdk.org
Tue Feb 14 14:11:34 UTC 2023


On Tue, 14 Feb 2023 09:01:32 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch prevents the `mailling bridge bot` from sending emails when a PR is draft.
>> And the related test case is added.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move the last draft invocation out of the method 'ignoreComment'. Adjust the API implementation.

forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java line 713:

> 711:                 .filter(obj -> obj.get("event").asString().equals("convert_to_draft"))
> 712:                 .map(obj -> ZonedDateTime.parse(obj.get("created_at").asString()))
> 713:                 .reduce((a, b) -> a.isBefore(b) ? b : a);

I think this could be expressed as `max()`.

-------------

PR: https://git.openjdk.org/skara/pull/1469


More information about the skara-dev mailing list